Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add notice that unshallowing takes time #10168

Merged
merged 1 commit into from Dec 30, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 28, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

I've noticed several people recently commenting that they were surprised at how long running the git fetch --unshallow command took (to the point where they thought it was not working). I ran a test locally and it took over 5 minutes for me to run.

This PR adds a line to the message letting users know that the command will take a while.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-29 at 22:15:30 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2020
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 30, 2020
@Rylan12 Rylan12 merged commit 4186cd9 into Homebrew:master Dec 30, 2020
@Rylan12 Rylan12 deleted the shallow-clone-message branch December 30, 2020 20:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 31, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants